Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EN and add PL translations #264

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix EN and add PL translations #264

merged 1 commit into from
Dec 18, 2024

Conversation

sheilagomes
Copy link
Contributor

What is the purpose of this pull request?

Add Polish messages file.

How to test it?

https://polish--inpostfresh.myvtex.com/admin

Types of changes

  • Chore (non-breaking change which doesn't change any functionalities)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly. (if none of the other choices apply)

Copy link

vtex-io-ci-cd bot commented Nov 5, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Nov 5, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

github-actions bot commented Nov 5, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 142, PR deletions = 3

Generated by 🚫 dangerJS against a40a4c0

Copy link

@cdcs0128 cdcs0128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are different IDs for singular and plural, why is this change?

messages/en.json Show resolved Hide resolved
@camilavcoutinho camilavcoutinho changed the title (WIP) Fix EN and add PL translations Fix EN and add PL translations Dec 11, 2024
@camilavcoutinho camilavcoutinho marked this pull request as ready for review December 11, 2024 12:55
@camilavcoutinho camilavcoutinho requested a review from a team as a code owner December 11, 2024 12:55
@cdcs0128 cdcs0128 self-requested a review December 16, 2024 14:54
Copy link

@williamvalderrama williamvalderrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translates into Polish as expected

image

Copy link

@cdcs0128 cdcs0128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@camilavcoutinho camilavcoutinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mecrano Mecrano merged commit 2e5035a into master Dec 18, 2024
23 of 25 checks passed
@Mecrano Mecrano deleted the add/polish branch December 18, 2024 17:06
Copy link

vtex-io-ci-cd bot commented Dec 18, 2024

Your PR has been merged! App is being published. 🚀
Version 3.15.1 → 3.16.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants